-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect account preselection for CSV import #4325
Comments
I wouldn't call this "bug". But it definitely would be a nice feature if PP remembered account pair selected per CSV import template (because such a template would usually correspond to a particular broker), instead of just remembering the last pair used. I don't think that removing remembering of the last used account pair (and starting from empty selection, thus forcing user to make selections on each import) is the right "fix", because most users don't have more than 1 account, and for them forcing repetitive selection would be significant drop in UX. Likewise, I don't think that making it configurable makes sense - PP already has too many configuration knobs, and most users don't know what's configurable and what's not and where a particular config option is located. |
Since suggestion 3 (pre-seleciton according to csv tempate) would be nice to have I think that suggestion 2 (prevent pre-selection for generic CSV import) is quite needed to prevent mistakes - this should not impact how it works for PDF imports though. |
Some folks here are getting progressively more annoyed by the need of extra clicks, so I started to look what could be done. I first wanted to do something on the CSV import dialog level, e.g. make selection of securities account propagate to select its reference account in the cash acc dropdown. But then I noticed that in cash acc list, there's context menu with "Import CSV...". Using it preselects that acc in the import dialog. That works, as folks would likely need to have acc list anyway to check balance before and after import. But of course, we need to preselect both accs. And in "portfolio list", there's no "Import CSV...", only "Import PDF..." Easy to fix: #4387 . But then "portfolio list" lacks balance of the reference account. I fixed that too, but too lazy to externalize strings. Probably will post it anyway. |
|
Describe the bug
For CSV imports accounts are pre-selected according to the last used account for any other CSV import so they are shared between imports from different banks/brokers. This may cause hard to recover mistakes of importing transactions to incorrect accounts.
Forum: https://forum.portfolio-performance.info/t/csv-import-improvements/29924
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The target accounts should not be pre-selected to 'Broker A' if I'm importing transactions for 'Broker B'.
Desktop
Details
There was Remember the last selected account/portfolio by the type of PDF document implemented which does not fit well for generic CSV imports.
I tried to disable pre-selection according to
extractor
in ReviewExtractedItemsPage.preselectDropDowns() but instead of CSVExtractor the private proxy is used.Example of stored accounts:
The first two are from CSV extrators that are generic (only "Type of data" is used as discriminator) and the last one is from PDF extractor that is bank/broker specific.
Suggested solution
The text was updated successfully, but these errors were encountered: