Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure client skips HTTPS verification #8698

Closed
WaysonWei opened this issue Mar 20, 2023 · 0 comments · Fixed by #8137
Closed

Azure client skips HTTPS verification #8698

WaysonWei opened this issue Mar 20, 2023 · 0 comments · Fixed by #8137
Labels
bug/need-confirmation kind/bug Applied to Bugs
Milestone
CE-2.18.0

Comments

@WaysonWei
Copy link
Contributor

WaysonWei commented Mar 20, 2023 •
edited
Loading

api/git/azure.go uses ``InsecureSkipVerify = true without the possibility of disabling it, which leads to potential attacks.
@WaysonWei WaysonWei changed the title 'object not found inside the database' error shown when browsing async edge snapshot Azure client skips HTTPS verification Mar 20, 2023
@WaysonWei WaysonWei linked a pull request Mar 20, 2023 that will close this issue
fix(azure): ensure azure client HTTPS verification #8137
Merged
@WaysonWei WaysonWei added this to the CE-2.18 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/need-confirmation kind/bug Applied to Bugs
Projects
None yet
Milestone
CE-2.18.0
Development

Successfully merging a pull request may close this issue.

fix(azure): ensure azure client HTTPS verification portainer/portainer
1 participant
@WaysonWei