Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming Translations For 'template header error' From Upstream #517

Closed
aaronskiba opened this issue Oct 24, 2023 · 2 comments
Closed

Incoming Translations For 'template header error' From Upstream #517

aaronskiba opened this issue Oct 24, 2023 · 2 comments
Assignees

Comments

@aaronskiba
Copy link
Collaborator

One of the incoming changes from the upstream releases is a modification to the file translation.fr-CA.yml. This modification would update French translations for the "Template Header Error" message.

Should we accept these changes? Currently, the file is using our current translations and the incoming translations are commented out. Should I leave it that way? Or would we prefer the incoming translations? Thank you.

# OPTION 1: OUR CURRENT TRANSLATIONS
one: 'Impossible d''enregistrer ce(tte) %{model} : 1 erreur'
other: 'Impossible d''enregistrer ce(tte) %{model} : %{count} erreurs'

# OPTION 2: NEW INCOMING TRANSLATIONS
one: " 1 erreur a empêché l’enregistrement de %{model}"
other: "%{count} erreurs ont empêché l’enregistrement de %{model} "
@lagoan
Copy link
Collaborator

lagoan commented Nov 6, 2023

@aaronskiba lets keep the original translations.

@aaronskiba
Copy link
Collaborator Author

This was addressed via PR #474.
(Additional Note: I don't think this file should've been manually edited anyway. Rather, it should be set automatically when the sync task is run with disable_yaml set to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants