Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno check fails for vendored postgresjs #574

Closed
ChristianSiegert opened this issue Mar 28, 2023 · 3 comments
Closed

deno check fails for vendored postgresjs #574

ChristianSiegert opened this issue Mar 28, 2023 · 3 comments

Comments

@ChristianSiegert
Copy link

ChristianSiegert commented Mar 28, 2023

Steps to reproduce:

  1. Create a .ts file and import postgresjs:
    // main.ts
    import "https://deno.land/x/[email protected]/mod.js";
  2. Run deno vendor main.ts
  3. Run deno check --import-map=vendor/import_map.json main.ts

Expected: No errors

Actual: Errors are reported for postgresjs:

Check file:///<redacted>/main.ts
error: TS2367 [ERROR]: This comparison appears to be unintentional because the types 'rmdirOptions | undefined' and 'boolean' have no overlap.
    if (options === false) {
        ~~~~~~~~~~~~~~~~~
    at file:///<redacted>/vendor/deno.land/[email protected]/node/_fs/_fs_rmdir.ts:82:9

Environment:

deno --version
deno 1.32.1 (release, x86_64-apple-darwin)
v8 11.2.214.9
typescript 5.0.2

Since the type checking error occurs in the std lib, I assume updating to a newer Deno std lib version will resolve the error.

@porsager
Copy link
Owner

Sounds about right.

@ChristianSiegert
Copy link
Author

The issue is closed but not resolved. porsager/postgres must update its imports of the Deno std lib to a newer version.

@bombillazo
Copy link

For some reason I cant use this library in deno due to this error:

TypeError: globalThis.addEventListener is not a function
    at new Process (https://deno.land/[email protected]/node/process.ts:194:16)
    at https://deno.land/[email protected]/node/process.ts:357:76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants