From 91b4216d67bed610cc941c953a622be79ed34d3d Mon Sep 17 00:00:00 2001 From: totomz Date: Fri, 16 Nov 2018 21:39:00 +0100 Subject: [PATCH] Fix for bug in porcli This workaround fix a nodejs issue (https://github.com/nodejs/node/issues/21771) that cause porcli to not work on windows --- packages/inquirer/lib/ui/baseUI.js | 10 +++++++++- packages/inquirer/package.json | 10 +++------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/packages/inquirer/lib/ui/baseUI.js b/packages/inquirer/lib/ui/baseUI.js index 973d2db51..c255a65fd 100644 --- a/packages/inquirer/lib/ui/baseUI.js +++ b/packages/inquirer/lib/ui/baseUI.js @@ -54,7 +54,15 @@ class UI { // Close the readline this.rl.output.end(); this.rl.pause(); - this.rl.close(); + + if (/^win/i.test(process.platform)) { + // @see https://github.com/nodejs/node/issues/21771 + // rl.close() breaks the event loop in @porketta.io/porcli + } + else { + this.rl.close(); + } + } } diff --git a/packages/inquirer/package.json b/packages/inquirer/package.json index 2b11be480..4df98e012 100644 --- a/packages/inquirer/package.json +++ b/packages/inquirer/package.json @@ -1,6 +1,6 @@ { - "name": "inquirer", - "version": "6.2.0", + "name": "@porketta.io/inquirer", + "version": "6.2.0-beta.2", "description": "A collection of common interactive command line user interfaces.", "author": "Simon Boudrias ", "files": [ @@ -30,11 +30,7 @@ "sinon": "^5.0.0" }, "scripts": { - "test": "nyc mocha test/**/* -r ./test/before", - "posttest": "nyc report --reporter=text-lcov > ../../coverage/nyc-report.lcov", - "prepublish": "nsp check", - "prepublishOnly": "cp ../../README.md .", - "postpublish": "rm -f README.md" + "test": "nyc mocha test/**/* -r ./test/before" }, "repository": "SBoudrias/Inquirer.js", "license": "MIT",