fix: 予選を同時に生成 #826
Open
fix: 予選を同時に生成 #826
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying kcmsx with
|
| Latest commit: |
8a15730
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b8c03c36.kcmsx.pages.dev |
| Branch Preview URL: | https://fix-594-simultaneous-generat.kcmsx.pages.dev |
speak-mentaiko
requested review from
laminne,
kiharu3112,
tufusa and
Suzune2741
tufusa
requested changes
Dec 17, 2024
There was a problem hiding this comment.
これだと定義と動作が乖離してしまっています(departmentTypeを受け取ってはいますが意味がないですよね)。以前のものをgenerateByDepartmentのような形で残して、新しくgenerateAllのようなメソッドを作るのが正しいと思います。
エンドポイントも、今のものを使うのはおかしいです(/match/pre/elementary/generateでelementaryもopenも生成されるのはおかしいですよね)。
命名についてコメントください > @laminne
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #594