You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i can see that we do not have a battery-level-100-charged-symbolic' but essentially it would be the equivalent of the -charging- one in our case. Here is a screenshot of the existing icons:
In continuation to the fix of #561 , from analysis of what gnome does here:
Gnome-shell's implementation here: https://github.com/GNOME/gnome-shell/blob/d60bdc95faf3607ec579558074cf1ca919db041a/js/ui/status/system.js#L19-L85
we should add an additional check for DeviceState.FULLY_CHARGED to not render any time to empty / time to full. & also render the thunder icon:
i can see that we do not have a battery-level-100-charged-symbolic' but essentially it would be the equivalent of the -charging- one in our case. Here is a screenshot of the existing icons:
Note: Checking that the battery-level == 100 to denote that it is fully-charged is a valid way to go from what i understand from this original implementation:
https://gitlab.freedesktop.org/upower/upower/-/blob/master/src/linux/up-device-idevice.c?ref_type=heads#L285-294
Somebody with a laptop that could test this thoroughly should pick this up.
The text was updated successfully, but these errors were encountered: