-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tests that evaluate stdout output #138
Comments
I'd like to replace the tests that are using output to determine if an action happened with creating tests that use test-doubles to verify the correction interactions like for example, these that I recently wrote: https://github.com/ponylang/corral/pull/132/files |
Did some work on this today, learned a bunch from this commit (7f00b2b). Hoping to have some updates landing soon 👍 |
@hasheddan are you interested in working on this? if yes, i can add you as a "contributor" to the ponylang org which basically allows you to be assigned to issues and not much else, then I can assign you to this. |
@SeanTAllen Definitely! Thanks 👍 |
ok @hasheddan once you accept the invite, you should be able to assign yourself as you will have "triage" level access to all the organization repos. |
Some of the integration tests evaluate that certain words are present in the stdout output, which can break or change with updates to the logging verbosity. The following tests specifically do this:
See #137 for more information.
@SeanTAllen would you like for these checks to just be removed from all of these tests? In
help
/info
/version
we would essentially just be testing exit 0.The text was updated successfully, but these errors were encountered: