Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address review comments of PR 40235 #105

Open
michielbdejong opened this issue Nov 29, 2023 · 1 comment
Open

Address review comments of PR 40235 #105

michielbdejong opened this issue Nov 29, 2023 · 1 comment

Comments

@michielbdejong
Copy link
Member

Specifically nextcloud/server#40235 (comment) about using events, and two smaller issues.

@michielbdejong
Copy link
Member Author

Need to think of a way to comply with https://github.com/nextcloud/server/pull/40235/files#r1390886920
Maybe have the MFA Checker app deal with this.
The more thorough option would be triggering additional pull requests in GSS, user_saml, and https://github.com/nextcloud/server/tree/master/lib/private/Authentication/TwoFactorAuth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant