Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen contract call argument types (BigNumber) #43

Closed
typedarray opened this issue Jan 7, 2023 · 0 comments
Closed

Loosen contract call argument types (BigNumber) #43

typedarray opened this issue Jan 7, 2023 · 0 comments

Comments

@typedarray
Copy link
Collaborator

Currently, the contract function types generated by abitype force you to pass a BigNumber for big int arguments, but the ethers.Contract object actually accepts BigNumberish types like number and string.

It doesn't seem like there is a way to distinguish between the argument type and the return type (the return type should stay the strict BigNumber)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@typedarray