Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Weights v2 #8188

Closed
KiChjang opened this issue Oct 2, 2022 · 4 comments · Fixed by #8217
Closed

Prepare for Weights v2 #8188

KiChjang opened this issue Oct 2, 2022 · 4 comments · Fixed by #8217

Comments

@KiChjang
Copy link

KiChjang commented Oct 2, 2022

With paritytech/substrate#12277 merged, we now need to ensure that the frontend can display the new Weight structure appropriately.

Some extrinsics won't have migrated yet, and will continue to use a wrapper struct called OldWeight(u64).

@jacogr
Copy link
Member

jacogr commented Oct 2, 2022

This is first - polkadot-js/api#5251 (quite a bitch since contracts need a lot of TLC to cater for old and new)

Before the above is in and available on a release, not much the UI can do. (There are significant changes UI-wise as well with mixtures of old and new and old or new. And obviously needs to cater for both current running and new master with detection and fallback)

@pepoviola
Copy link

With paritytech/substrate#12277 merged, we now need to ensure that the frontend can display the new Weight structure appropriately.

Some extrinsics won't have migrated yet, and will continue to use a wrapper struct called OldWeight(u64).

Hi @KiChjang, just for tracking purpose. This is the cause of the failure for this job: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/1903873

Thanks!

@jacogr
Copy link
Member

jacogr commented Oct 4, 2022

The UI itself is now robust enough (after the PRs referencing the issue) to support both chains with weight v1 and those with weight v2.

However, v2 won't work until we have had an API upgrade. (As soon as a release is cut there, aka master branch of API works, but unreleased)

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants