Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending payouts are not displayed in the payout page #11071

Closed
4 of 10 tasks
Leouarz opened this issue Nov 7, 2024 · 6 comments · Fixed by #11079
Closed
4 of 10 tasks

Pending payouts are not displayed in the payout page #11071

Leouarz opened this issue Nov 7, 2024 · 6 comments · Fixed by #11079
Assignees
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.

Comments

@Leouarz
Copy link

Leouarz commented Nov 7, 2024

  • I'm submitting a ...
  • Bug report
  • Feature request
  • Support request
  • Other
  • What is the current behavior and expected behavior?

Pending payout should be displayed in the payouts tab.
Few weeks ago, the payout section was showing eras already paid. This issue was tracked here
It was recently closed, as a fixed was pushed and deployed.
Now no eras is shown in the payout page.

Before the fix, the bug was indeed there, eg. in here, eras 212 and 215 are already claimed and still showing:
image

After the fix, no era is displayed:
image

In comparison, in the staking dashboard, we have this:
image

To reproduce, here is the required data on Avail testnet:

Don't hesitate in case you need any other information.

  • What is the motivation for changing the behavior?

Allowing users to claimed some era rewards or all of them.

  • Please tell us about your environment:
  • Version:

    • API: v14.2.3
    • Apps: v0.145.2-15
  • Environment:

    • Node.js
    • Browser
    • Other (limited support for other environments)
  • Language:

    • JavaScript
    • TypeScript (include tsc --version)
    • Other
@TarikGul
Copy link
Member

TarikGul commented Nov 7, 2024

Interesting, must be a parsing issue in apps. The api now returns a isClaimed field in each of the rewards. I will check this out.

@TarikGul TarikGul added P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow. Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. labels Nov 7, 2024
@Leouarz
Copy link
Author

Leouarz commented Nov 7, 2024

Thanks, i saw the isClaimed field being used, and while adding logs in the api, i saw the rewards coming with isClaimed being correctly false, then they are all set tu claimed in this piece of code. I did not went further to be honest

@the-nodelab
Copy link

This is also happening with the Tangle RPC (wss://rpc.tangle.tools).
Example account is tgGv1ckHJRCzpggcPyZxeyK2T9PugDogZSd9X9q4jFWWZLVJS

@TarikGul
Copy link
Member

Thank you @Leouarz for the extra info - it definitely helped narrow it down faster. The problem was indeed that line. PR in the api: polkadot-js/api#6026

Hopefully this will resolve the issue! I need to release it in the api first then propogate it to apps later in the week.

@Leouarz
Copy link
Author

Leouarz commented Nov 12, 2024

Hey @TarikGul, just tested the changes by applying them manually, they seem to work as expected, thank you ! Waiting for the release.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.
Development

Successfully merging a pull request may close this issue.

4 participants