-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more integrations tests to People chains #499
base: main
Are you sure you want to change the base?
Add more integrations tests to People chains #499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good! 👍
Please add the same to https://github.com/paritytech/polkadot-sdk/tree/master/cumulus/parachains/integration-tests/emulated/tests/people to keep the covered functionality in sync.
@acatangiu certainly. Thanks for the review! |
Why? |
fec09e0
to
a780f51
Compare
Review required! Latest push from author must always be reviewed |
1 similar comment
Review required! Latest push from author must always be reviewed |
To test the following example, you'll need to:
Consider the following encoded call:
Now either
In either instance, you will find, in the people chain's "recent events" list, @bkchr in conclusion, and to answer your question: I don't know why this happens, but I suspect it shouldn't. I've been working to understand why, and this PR, as well as paritytech/polkadot-sdk#6377 (comment) are how. |
@seadanda also, apologies for the delay: the above comment contains the snippet I mentioned in DMs. My identity should exist when you fork the chain. |
# Description Made as a follow-up of polkadot-fellows/runtimes#499 ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Dónal Murray <[email protected]>
Like I said in paritytech/polkadot-sdk#6377 (comment), knowing the reason for the differential failures in the wrong origin tests does not impact their immediate usefulness, so this can be merged, and that matter considered in another issue/PR. |
# Description Made as a follow-up of polkadot-fellows/runtimes#499 ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Dónal Murray <[email protected]>
There was a problem running the action.❌😵❌ Please find more information in the logs. |
# Description Made as a follow-up of polkadot-fellows/runtimes#499 ## Integration N/A ## Review Notes N/A --------- Co-authored-by: Dónal Murray <[email protected]>
https://github.com/open-web3-stack/polkadot-ecosystem-tests relies on chopsticks to create E2E tests using periodically (roughly daily) obtained runtimes from production relay chains/system parachains.
In particular, open-web3-stack/polkadot-ecosystem-tests#63 does this for the People chains.
In writing those tests, I was unable to use XCM to test
pallet_identity::{kill_identity/add_username_authority/remove_username_authority}
.I wrote this PR to replicate those tests at this layer, whose passing status falsify the hypothesis that there may have been an issue with the runtimes, and confirm that it was a problem with the way I wrote those tests.