Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Aura-specific dependency optional #1514

Open
nazar-pc opened this issue Sep 20, 2024 · 0 comments
Open

Make Aura-specific dependency optional #1514

nazar-pc opened this issue Sep 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nazar-pc
Copy link

Motivation

We use frontier in a project with custom consensus and s[c|p]-consensus-aura dependencies are just extra things for us to build that we will not use.

Suggested Solution

Hide Aura-specific dependencies (sp-consensus-aura, sc-consensus-aura doesn't seem to be used at all and should be removed) in fc-rpc behind optional (even if enabled by default) feature, so it can be disabled.

Alternatives

Alternative would be to remove it from RPC completely since anyone should be able to implement AuraConsensusDataProvider in their codebase, but I assume there was a reason for it to exist, so I didn't suggest removing it outright.

@nazar-pc nazar-pc added the enhancement New feature or request label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant