[WIP] Link messages to campaign contacts #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-pr-p
reviewed
Feb 26, 2019
src/server/api/lib/twilio.js
Outdated
| @@ -44,6 +44,7 @@ async function convertMessagePartsToMessage(messageParts) { | |||
| contactNumber | |||
| }) | |||
| return new Message({ | |||
| campaign_contact_id: lastMessage.campaign_contact_id, | |||
There was a problem hiding this comment.
this should be
lastMessage && lastMessage.campaign_contact_id
We should still save it in the db I think!
There was a problem hiding this comment.
Below references it directly with assignment_id: lastMessage.assignment_id, should we change there as well or assume that's working with the unsafe reference?
There was a problem hiding this comment.
Ooof, good point. I would say yes – that would cause an uncaught exception, and our application should have no uncaught exceptions, yeah?
There was a problem hiding this comment.
Or we should enforce that lastMessage exists and ignore incoming messages that aren't associated with a campaign
There was a problem hiding this comment.
I see no harm to saving them, and then maybe in like a week looking at what they are?
bchrobot
pushed a commit
that referenced
this pull request
Feb 27, 2019
…messages Link messages to campaign contacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We either need to allow null values for campaign_contact_id or we need to do a three-part migration: adding a nullable column, associating all messages with their campaigns, and making the column non-nullable.