Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add second pass option and mysql branch postgres compatibility fixes #39

Merged
merged 2 commits into from
Feb 16, 2019
Merged

Add second pass option and mysql branch postgres compatibility fixes #39

merged 2 commits into from
Feb 16, 2019

Conversation

ben-pr-p
Copy link
Contributor

No description provided.

bchrobot
bchrobot requested changes Feb 16, 2019
View reviewed changes
Copy link
Member

@bchrobot bchrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise 👍

src/workers/jobs.js Outdated
@@ -697,6 +697,8 @@ export async function assignTexters(job) {
const assignmentIds = await r.knex('assignment')
.transacting(trx)
.insert(assignmentInserts)
.returning('id')
console.log(assignmentIds)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop log statement

@ben-pr-p ben-pr-p merged commit 23e82db into politics-rewired/deploy Feb 16, 2019
@bchrobot bchrobot deleted the politics-rewired/add-second-pass branch February 27, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchrobot bchrobot bchrobot requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-pr-p @bchrobot