Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asynchronous text sending #31

Merged
merged 4 commits into from
Feb 15, 2019
Merged

Asynchronous text sending #31

merged 4 commits into from
Feb 15, 2019

Conversation

ben-pr-p
Copy link
Contributor

@ben-pr-p ben-pr-p commented Feb 14, 2019 •
edited
Loading

Tested:

  1. Properly handle click functionality on UI error
  2. Errors get removed over time
  3. Snackbar is wider to accommodate longer error messages
  4. Proper stacking

@ben-pr-p ben-pr-p changed the title [WIP] asynchronous text sending Asynchronous text sending Feb 15, 2019
@ben-pr-p ben-pr-p requested a review from bchrobot February 15, 2019 15:01
bchrobot
bchrobot requested changes Feb 15, 2019
View reviewed changes
src/components/AssignmentTexter.jsx Outdated Show resolved Hide resolved
src/components/AssignmentTexter.jsx Outdated Show resolved Hide resolved
src/containers/AssignmentTexterContact.jsx Outdated Show resolved Hide resolved
@bchrobot bchrobot merged commit 0fe57e2 into politics-rewired/deploy Feb 15, 2019
@bchrobot bchrobot deleted the politics-rewired/asynchronous-text-sending branch February 15, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchrobot bchrobot bchrobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-pr-p @bchrobot