Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Slack based authentication method #19

Merged
merged 4 commits into from
Feb 5, 2019
Merged

Add a Slack based authentication method #19

merged 4 commits into from
Feb 5, 2019

Conversation

ben-pr-p
Copy link
Contributor

@ben-pr-p ben-pr-p commented Feb 5, 2019 •
edited
Loading

Adds environment variables:

PASSPORT_STRATEGY=
SLACK_CLIENT_ID=
SLACK_CLIENT_SECRET=
SLACK_TEAM_NAME=

Added a package so run npm install

@ben-pr-p ben-pr-p requested a review from bchrobot February 5, 2019 14:41
bchrobot
bchrobot requested changes Feb 5, 2019
View reviewed changes
Copy link
Member

@bchrobot bchrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple requests for comments, but other than that 👍

src/server/index.js Show resolved Hide resolved
src/server/auth-passport.js Outdated Show resolved Hide resolved
src/components/Login.jsx Show resolved Hide resolved
@ben-pr-p ben-pr-p merged commit e460754 into politics-rewired/deploy Feb 5, 2019
@bchrobot bchrobot deleted the politics-rewired/slack-auth branch February 5, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchrobot bchrobot bchrobot requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-pr-p @bchrobot