Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin bulk script replacement #106

Merged
merged 4 commits into from
Apr 5, 2019
Merged

Admin bulk script replacement #106

merged 4 commits into from
Apr 5, 2019

Conversation

bchrobot
Copy link
Member

@bchrobot bchrobot commented Apr 4, 2019 •
edited
Loading

Screen Shot 2019-04-05 at 4 27 41 PM

@bchrobot bchrobot changed the title [WIP] Admin bulk script replacement Admin bulk script replacement Apr 5, 2019
@bchrobot
Copy link
Member Author

bchrobot commented Apr 5, 2019 •
edited
Loading

I don't know if we want to escape search patterns in both script and campaign title. * in script text needs to be escaped with a backslash and I think % will still work as a wildcard in the campaign title.

@bchrobot bchrobot requested a review from ben-pr-p April 5, 2019 20:23
@bchrobot bchrobot merged commit 612c917 into politics-rewired/deploy Apr 5, 2019
@bchrobot bchrobot deleted the politics-rewired/bulk-script-replacer branch April 5, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-pr-p ben-pr-p ben-pr-p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bchrobot @ben-pr-p