fix unit tests

db_test.go

@@ -1456,9 +1456,9 @@ func TestDBRecover(t *testing.T) {
 			require.NoError(t, err)
 			snapshotTxns = append(snapshotTxns, tx)
 		}
-		expectedSnapshots := []uint64{2, 3}
+		expectedSnapshots := []uint64{3, 5}
 		if blockRotation {
-			expectedSnapshots = append(expectedSnapshots, 6)
+			expectedSnapshots = append(expectedSnapshots, 8)
 		}
 		require.Equal(t, expectedSnapshots, snapshotTxns)
 		return dir
@@ -2975,7 +2975,7 @@ func Test_DB_SnapshotNewerData(t *testing.T) {
 			}
 
 			// Get a snapshot tx
-			tx := db.beginRead()
+			tx, _, commit := db.begin()
 
 			// Insert another write, and force compaction
 			samples := dynparquet.GenerateTestSamples(3)
@@ -2986,7 +2986,18 @@ func Test_DB_SnapshotNewerData(t *testing.T) {
 			require.NoError(t, table.EnsureCompaction())
 
 			// Now perform the snapshot
+			db.Wait(tx - 1)
+			err = db.wal.Log(
+				tx,
+				&walpb.Record{
+					Entry: &walpb.Entry{
+						EntryType: &walpb.Entry_Snapshot_{Snapshot: &walpb.Entry_Snapshot{Tx: tx}},
+					},
+				},
+			)
+			require.NoError(t, err)
 			require.NoError(t, db.snapshotAtTX(ctx, tx, db.offlineSnapshotWriter(tx)))
+			commit()
 			require.NoError(t, db.wal.Truncate(tx))
 			time.Sleep(1 * time.Second) // wal flushes every 50ms
 

index/lsm_test.go

@@ -96,7 +96,7 @@ func Test_LSM_Basic(t *testing.T) {
 		{Level: L1, MaxSize: 1024 * 1024 * 1024, Type: CompactionTypeParquetMemory, Compact: compactParts},
 		{Level: L2, MaxSize: 1024 * 1024 * 1024},
 	},
-		func(uint64) {},
+		func() uint64 { return math.MaxUint64 },
 	)
 	require.NoError(t, err)
 
@@ -131,7 +131,7 @@ func Test_LSM_DuplicateSentinel(t *testing.T) {
 		{Level: L1, MaxSize: 1024 * 1024 * 1024, Type: CompactionTypeParquetMemory, Compact: compactParts},
 		{Level: L2, MaxSize: 1024 * 1024 * 1024},
 	},
-		func(uint64) {},
+		func() uint64 { return math.MaxUint64 },
 	)
 	require.NoError(t, err)
 
@@ -155,7 +155,7 @@ func Test_LSM_Compaction(t *testing.T) {
 		{Level: L0, MaxSize: 1, Type: CompactionTypeParquetMemory, Compact: compactParts},
 		{Level: L1, MaxSize: 1024 * 1024 * 1024},
 	},
-		func(uint64) {},
+		func() uint64 { return math.MaxUint64 },
 	)
 	require.NoError(t, err)
 
@@ -178,7 +178,7 @@ func Test_LSM_CascadeCompaction(t *testing.T) {
 		{Level: 3, MaxSize: 2281, Type: CompactionTypeParquetMemory, Compact: compactParts},
 		{Level: 4, MaxSize: 2281},
 	},
-		func(uint64) {},
+		func() uint64 { return math.MaxUint64 },
 	)
 	require.NoError(t, err)
 
@@ -211,7 +211,7 @@ func Test_LSM_InOrderInsert(t *testing.T) {
 		{Level: L1, MaxSize: 1024 * 1024 * 1024, Type: CompactionTypeParquetMemory, Compact: compactParts},
 		{Level: L2, MaxSize: 1024 * 1024 * 1024},
 	},
-		func(uint64) {},
+		func() uint64 { return math.MaxUint64 },
 	)
 	require.NoError(t, err)
 

snapshot.go

@@ -427,7 +427,7 @@ func WriteSnapshot(ctx context.Context, tx uint64, db *DB, w io.Writer, offline
 				},
 			}
 
-			if err := block.Index().Snapshot(func(p parts.Part) error {
+			if err := block.Index().Snapshot(tx, func(p parts.Part) error {
 				granuleMeta := &snapshotpb.Granule{}
 				partMeta := &snapshotpb.Part{
 					StartOffset:     int64(offW.offset),