Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add equi joins to new streaming engine #19869

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Nov 19, 2024

Still a work in progress, do not merge.

@orlp orlp changed the title refactor(rust): Add equi join to new streaming engine refactor(rust): Add equi joins to new streaming engine Nov 19, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0.46904% with 1061 lines in your changes missing coverage. Please review.

Project coverage is 79.10%. Comparing base (426cf27) to head (a83f38e).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 649 Missing ⚠️
...s/polars-expr/src/chunked_idx_table/row_encoded.rs 0.00% 232 Missing ⚠️
crates/polars-expr/src/hash_keys.rs 0.00% 123 Missing ⚠️
crates/polars-utils/src/idx_map/bytes_idx_map.rs 0.00% 14 Missing ⚠️
crates/polars-core/src/frame/mod.rs 30.00% 7 Missing ⚠️
crates/polars-utils/src/index.rs 25.00% 6 Missing ⚠️
crates/polars-core/src/datatypes/field.rs 0.00% 4 Missing ⚠️
crates/polars-ops/src/frame/join/args.rs 0.00% 4 Missing ⚠️
crates/polars-stream/src/nodes/in_memory_map.rs 0.00% 4 Missing ⚠️
crates/polars-stream/src/nodes/in_memory_source.rs 0.00% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19869      +/-   ##
==========================================
- Coverage   79.43%   79.10%   -0.33%     
==========================================
  Files        1551     1559       +8     
  Lines      215222   217441    +2219     
  Branches     2452     2456       +4     
==========================================
+ Hits       170954   172014    +1060     
- Misses      43710    44869    +1159     
  Partials      558      558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant