Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained wasm-timer dependency #10314

Closed
jqnatividad opened this issue Aug 5, 2023 · 2 comments · Fixed by #10347
Closed

Replace unmaintained wasm-timer dependency #10314

jqnatividad opened this issue Aug 5, 2023 · 2 comments · Fixed by #10347
Assignees
@orlp
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature internal An internal refactor or improvement rust Related to Rust Polars

Comments

@jqnatividad
Copy link
Contributor

jqnatividad commented Aug 5, 2023 •
edited
Loading

Problem description

in https://github.com/pola-rs/polars/blob/main/crates/polars-core/Cargo.toml

see tomaka/wasm-timer#21 (comment)
@jqnatividad jqnatividad added the enhancement New feature or an improvement of an existing feature label Aug 5, 2023
@universalmind303 universalmind303 added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 5, 2023
@orlp
Copy link
Collaborator

orlp commented Aug 7, 2023 •
edited
Loading

We only use the crate in one place as far as I can see, to choose a unique ID for the categorical string cache. It's probably better if that uses a non-time based approach anyway.

@orlp orlp added the accepted Ready for implementation label Aug 7, 2023
@orlp orlp self-assigned this Aug 7, 2023
@github-project-automation github-project-automation bot moved this to Ready in Backlog Aug 7, 2023
@orlp orlp mentioned this issue Aug 7, 2023
Merged
@github-project-automation github-project-automation bot moved this from Ready to Done in Backlog Aug 7, 2023
@jqnatividad
Copy link
Contributor Author

Nice! Removed a lot of unneeded dependencies too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orlp orlp

Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature internal An internal refactor or improvement rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rust): remove wasm-timer dependency orlp/polars
3 participants
@orlp @jqnatividad @universalmind303