Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Expose GetPathBit() #15

Merged
merged 1 commit into from
Jun 29, 2023
Merged

[Minor] Expose GetPathBit() #15

merged 1 commit into from
Jun 29, 2023

Conversation

h5law
Copy link
Collaborator

@h5law h5law commented Jun 29, 2023

Overview

This PR exposes GetPathBit() for use outside of the SMT repo

@h5law h5law requested a review from Olshansk June 29, 2023 19:13
@h5law h5law self-assigned this Jun 29, 2023
@reviewpad reviewpad bot added small Pull request is small waiting-for-review This PR is currently waiting to be reviewed labels Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.14 🎉

Comparison is base (dd8ae60) 86.78% compared to head (f57fcbf) 86.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   86.78%   86.93%   +0.14%     
==========================================
  Files           8        8              
  Lines         984      995      +11     
==========================================
+ Hits          854      865      +11     
  Misses         94       94              
  Partials       36       36              
Impacted Files Coverage Δ
smt.go 79.10% <90.00%> (ø)
proofs.go 90.44% <100.00%> (ø)
utils.go 93.81% <100.00%> (+0.79%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this

@h5law h5law merged commit f5ef955 into main Jun 29, 2023
@h5law h5law deleted the path-bit-exposed branch June 29, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review This PR is currently waiting to be reviewed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants