[P2P][LibP2P][SPIKE] Consolidate and Refactor Node Identity

[jessicadaugherty]

Objective

Research and design an implementation plan for consolidating naming patterns between Address & Peer throughout the codebase.

Origin Document

In the consensus module, we define a NodeId in types.go.

In the P2P module, we maintain addr books and lists:

In LibP2P, we have a PeerID:

Goals

• Identifying all the different parts in the codebase that need to be updated to simplify and consolidate IDs
• LibP2P ↔ Pocket identity mapping: determine whether to centralize the mappers in one place or adopt LibP2P address as a base

Deliverables

• A design document that recommends how to simplify the codebase and consolidate the use of the same IDs with a single source of truth that includes:
  • Replacing NodeId in consensus with node-wide identity
  • A decision on if we support multi-address or not
  • How to expose/advertise identity through RPC appropriately
  • Required cleanup configurations for node runners related to identity
  • Decide & design if using one PrivateKey for all modules or on a per module level
  • Show how different modules are connecting via this ID

Non-Goals / Deliverables

• Peer discovery or churn
• Using the same private key for each module

General issue checklist

• Update the appropriate CHANGELOG
• Update the README
• If applicable, update the source code tree explanation
• If applicable, add or update a state, sequence or flowchart diagram using mermaid
• Update any relevant global documentation & references
• Document small issues / TODOs along the way

---

Creators: @jessicadaugherty @Olshansk