Use react-helmet props rather than children

Avoids the error at nfl/react-helmet#373 where the maximum call stack size is exceeded because of a deepEqual on React children.
poketo · Dec 12, 2018 · 98c4e19 · 98c4e19
1 parent 51e2a8a
commit 98c4e19
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 18 deletions.
diff --git a/src/views/about-view.js b/src/views/about-view.js
@@ -21,9 +21,7 @@ const QuestionContainer = ({ id, question, children }) => (
 
 export default () => (
   <HomeLayout>
-    <Head>
-      <title>About</title>
-    </Head>
+    <Head title="About" />
     <Header />
     <ScrollReset />
     <div className="mw-500 mh-auto pt-4 pt-5-m">

diff --git a/src/views/log-in-view.js b/src/views/log-in-view.js
@@ -117,9 +117,7 @@ class LogInView extends Component<Props, State> {
 
     return (
       <div className="mh-100vh c-gray4 bgc-offwhite fs-16 fs-18-m">
-        <Head>
-          <title>Log In</title>
-        </Head>
+        <Head title="Log In" />
         <HomeHeader />
         <div className="pt-4 ph-3 mw-500 mh-auto ta-center">
           {hasUniqueRedirect &&

diff --git a/src/views/log-out-view.js b/src/views/log-out-view.js
@@ -22,9 +22,7 @@ class LogOutView extends Component<Props> {
   render() {
     return (
       <HomeLayout>
-        <Head>
-          <title>Logging out</title>
-        </Head>
+        <Head title="Logging out" />
         <div className="pa-3 x xd-column xa-center xj-center mh-100vh">
           <p>Logging out...</p>
         </div>

diff --git a/src/views/not-found-view.js b/src/views/not-found-view.js
@@ -8,9 +8,7 @@ import HomeLayout from '../components/home-layout';
 
 export default () => (
   <HomeLayout>
-    <Head>
-      <title>Not found</title>
-    </Head>
+    <Head title="Not Found" />
     <div className="pa-3 x xd-column xa-center xj-center mh-100vh">
       <div className="mb-4">
         <svg

diff --git a/src/views/reader-view.js b/src/views/reader-view.js
@@ -267,9 +267,7 @@ class ReaderView extends Component<Props> {
 
     return (
       <Fragment>
-        <Head>
-          <title>{`${series.title} – ${chapterLabel}`}</title>
-        </Head>
+        <Head title={`${series.title} – ${chapterLabel}`} />
         <div className="pt-5 pb-4 mh-auto w-90p-m ta-center mw-900">
           <div className="pt-4">
             <ReaderPageImageList pages={chapter.pages} />

diff --git a/src/views/series-view.js b/src/views/series-view.js
@@ -92,9 +92,7 @@ const SeriesPage = ({
   return (
     <div className="pb-5">
       <ScrollReset />
-      <Head>
-        <title>{series.title}</title>
-      </Head>
+      <Head title={series.title} />
       <div className="mw-600 w-100p mh-auto p-relative">
         <header className="p-relative z-3 x xa-center xj-spaceBetween pa-2 mb-3 c-white">
           <BackButtonContainer>