Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management for manifests #55

Open
saheljalal opened this issue Feb 4, 2022 · 0 comments
Open

Dependency management for manifests #55

saheljalal opened this issue Feb 4, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@saheljalal
Copy link
Collaborator

saheljalal commented Feb 4, 2022

When docking a manifest using nostromo dock it pulls down one or more manifests locally. Now that we have support for multiple manifests, it will be likely that users will split functionality up with more granularity. In some cases, it could be that a manifest command may depend on another that isn't in the same manifest.

To be able to build composable manifests, we can add a dependencies field that includes sources for other manifests. On sync functionality (sync, dock, undock) we can automatically ingest or delete these additional manifests.

Proposed model.Manifest updates:

struct LinkedManifest {
    UUID string
    Name string
    Source string
}

struct Manifest {
    ...
    links []*LinkedManifest
}

Store the UUID for now in case we can support versioning in the future.

Add a new command to link manifests together:

nostromo link <source> <target>

This command, similar to dock, should download the manifest, parse it, store it, and add the dependency record in the target manifest.

Note that care should be taken with collision detection and circular references. Need a solution to avoid problems with these scenarios.

@saheljalal saheljalal added enhancement New feature or request help wanted Extra attention is needed labels Feb 4, 2022
@saheljalal saheljalal changed the title Dependency management support for manifests Dependency management for manifests Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant