Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player is never ready #102

Open
benedikt-buchert opened this issue Feb 4, 2022 · 5 comments
Open

Player is never ready #102

benedikt-buchert opened this issue Feb 4, 2022 · 5 comments

Comments

@benedikt-buchert
Copy link

benedikt-buchert commented Feb 4, 2022

When executing:
const iframe = document.createElement('iframe');
iframe.src = 'https://researchvr.podigee.io/92-researchvr88/embed?context=external';
document.body.appendChild(iframe);

const player = new playerjs.Player(iframe);

player.isReady stays false even when the player is ready.

When testing here I also can not get the event to work:
http://playerjs.io/test.html?url=https%3A%2F%2Fresearchvr.podigee.io%2F92-researchvr88%2Fembed%3Fcontext%3Dexternal

@benedikt-buchert
Copy link
Author

I also only see a resize event being sent via post message. No events with context: 'player.js',

@andygrunwald
Copy link

I had the same problem with the version X from the CDN.

I forked the repo into https://github.com/EngineeringKiosk/podigee-podcast-player/tree/development, updated all dependencies, compiled it and using a local version now.
See here the differences of the fork: https://github.com/EngineeringKiosk/podigee-podcast-player/tree/development#fork-notice

You can find a working version of the player.js events here: https://github.com/EngineeringKiosk/webpage/pull/81/files#diff-1f17be1ad22cddc1e0bfcf3389eaba97c2bdde4df4434641e699a4c806424a34

@mgrsskls
Copy link

mgrsskls commented Nov 4, 2022

@andygrunwald I am having the same problem and tried your fork, but that didn't help me unfortunately. I actually don't see any changes in your fork which could fix that? Do you have any other hints for me on how you got it working with your fork?

@mgrsskls
Copy link

mgrsskls commented Nov 4, 2022

I just realized what the issue is: Podigee has a new CDN which is https://player.podigee-cdn.net. So you need to use that one instead of https://cdn.podigee.com.

@andygrunwald
Copy link

@mgrsskls If you clone https://github.com/EngineeringKiosk/podigee-podcast-player, ensure to use the branch development.
Once this is checked out, you can run:

Install the dependencies:

make init

Build the package:

make build

Then you can get the updated javascript package from the build/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants