Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not an issue - but reco to improve load times #101

Open
alexanderdross opened this issue Sep 29, 2021 · 0 comments
Open

not an issue - but reco to improve load times #101

alexanderdross opened this issue Sep 29, 2021 · 0 comments

Comments

@alexanderdross
Copy link

I recommend to update the example code below

https://github.com/podigee/podigee-podcast-player#inline-configuration
add an "async" attribute to the script to ensure player is not render blocking
current:

<script class="podigee-podcast-player" src="https://cdn.podigee.com/podcast-player/javascripts/podigee-podcast-player.js" data-configuration="playerConfiguration"></script>

async added

<script class="podigee-podcast-player" **async** src="https://cdn.podigee.com/podcast-player/javascripts/podigee-podcast-player.js" data-configuration="playerConfiguration"></script>

https://github.com/podigee/podigee-podcast-player#simple-iframe-with-external-configuration

<iframe class="podigee-podcast-player" src="https://cdn.podigee.com/podcast-player/podigee-podcast-player.html?configuration=https://example.com/my-podcast-episode.json"></script>

added title attribute and lazy load

<iframe class="podigee-podcast-player" **loading="lazy" title="value of title here"** src="https://cdn.podigee.com/podcast-player/podigee-podcast-player.html?configuration=https://example.com/my-podcast-episode.json"></script>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant