Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetSSL_Win: TLS handshake may fail for non-blocking sockets #4779

Closed
obiltschnig opened this issue Nov 23, 2024 · 0 comments · Fixed by #4787
Closed

NetSSL_Win: TLS handshake may fail for non-blocking sockets #4779

obiltschnig opened this issue Nov 23, 2024 · 0 comments · Fixed by #4787

Comments

@obiltschnig
Copy link
Member

obiltschnig commented Nov 23, 2024

The implementation of the TLS handshake in NetSSL_Win may fail with non-blocking sockets as a negative return value from receiveBytes() or a short write is not properly handled. May require rewrite of the entire handshaking code (state machine).

Furthermore, the state machine may block for up to 200 ms at a time due to a call to select(). This is not acceptable for non-blocking code.

@obiltschnig obiltschnig added this to the Release 1.15.0 milestone Nov 23, 2024
@obiltschnig obiltschnig self-assigned this Nov 23, 2024
@matejk matejk modified the milestones: Release 1.15.0, Release 1.14.0 Nov 25, 2024
@matejk matejk added this to 1.14 Nov 25, 2024
@matejk matejk moved this to In Progress in 1.14 Nov 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.14 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants