Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added forceExclude #289

Merged
merged 1 commit into from
May 11, 2019
Merged

Added forceExclude #289

merged 1 commit into from
May 11, 2019

Conversation

futureweb
Copy link
Contributor

#243
Signed-off-by: Andreas Schnederle-Wagner [email protected]

@futureweb
Added forceExclude
66385a0 
#243
Signed-off-by: Andreas Schnederle-Wagner <[email protected]>
@futureweb futureweb mentioned this pull request May 9, 2019
Closed
@pocketjoso
Copy link
Owner

Thanks for the PR and great job with your first contribution written for Node! 👏
Just heads up - after merging I will do some minor code clean up just to avoid repetition, but don't worry about that.

@pocketjoso pocketjoso merged commit bbc4d3a into pocketjoso:master May 11, 2019
@pocketjoso
Copy link
Owner

Just if you are curious:

  • tidy up in this commit: c8acaaa
  • made test pass in this commit: 2d0c3df

Thanks again!

@futureweb
Copy link
Contributor Author

makes sense to consolidate the 2 Functions ... should have thought about that forehand ... ;-)
#JuniorClassCodingKnowledge 🙈😂

@pocketjoso
Copy link
Owner

Hehe no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futureweb @pocketjoso