-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for windows development #236
Comments
Great initiative. 👍 For most tests it is hopefully just cleaning up Note in general that I have been touching quite a lot of the core code recently just to play around with running more processes in parallel to increase performance. To update the tests it should not be needed to look at the core code, but headsup just in case. |
So far I have had luck with +return 'file://' + path.join(__dirname, 'static-server', file)
-return 'file://' + path.join(process.env.PWD, 'test', 'static-server', file) This alone made all tests pass on windows, so I guess supporting it is really simple. Should I just create a PR with this, and maybe a AppVeyor config? Edit: All the tests in |
Hmm I had issues with |
This package works great on windows, however as it is right now it's not testable on windows. As seen in #234 this can course some issues when trying to contribute with a windows machine.
For windows support, the first step is to make all the tests support windows, and then enable a appveyor build, to keep it tested and supported.
This issues is tracking this progress and discussion. I intend to take a look at this at some point.
The text was updated successfully, but these errors were encountered: