You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand that this has been a (touchy) subject that has come up a couple of times before (#896, #924), but the state of affairs hasn't be reevaluated since those discussions five years ago.
As mentioned by @ZacSweershere, one of the main reasons for using Material Dialogs is that they use sensible widths for dialogs on tablet. To see the validity of this statement as it stands today, I've taken an assortment of screenshots taken on a phone (Pixel 2, Android Pie) and a table (Nexus 10 emulator, Android Pie) comparing Material Dialog and the androidx dialog.
Phone
Current (Material Dialog)
Proposed (Androidx Dialog)
Tablet
Current (Material Dialog)
Proposed (Androidx Dialog)
The margins are virtually indistinguishable between the Material Dialog and androidx dialog.
I must admit that the second argument made in the same comment regarding Material Dialog's supposed superior customizability has not been investigated, though if not true has not been obviously utilized by the app.
Therefore, my proposition is to replace the use of Material Dialogs with the dialog provided by androidx. Such a switch allows the removal of an seemingly unnecessary dependency.
The text was updated successfully, but these errors were encountered:
Please read the contributing guidelines before making snarky comments. It's true that this isn't a core problem, but there is a reason why I didn't label it "priority".
I understand that this has been a (touchy) subject that has come up a couple of times before (#896, #924), but the state of affairs hasn't be reevaluated since those discussions five years ago.
As mentioned by @ZacSweers here, one of the main reasons for using Material Dialogs is that they use sensible widths for dialogs on tablet. To see the validity of this statement as it stands today, I've taken an assortment of screenshots taken on a phone (Pixel 2, Android Pie) and a table (Nexus 10 emulator, Android Pie) comparing Material Dialog and the androidx dialog.
Phone
Tablet
The margins are virtually indistinguishable between the Material Dialog and androidx dialog.
I must admit that the second argument made in the same comment regarding Material Dialog's supposed superior customizability has not been investigated, though if not true has not been obviously utilized by the app.
Therefore, my proposition is to replace the use of Material Dialogs with the dialog provided by androidx. Such a switch allows the removal of an seemingly unnecessary dependency.
The text was updated successfully, but these errors were encountered: