Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) finalize immediately with the last vote #91

Closed
vbaranov opened this issue May 18, 2018 · 4 comments
Closed

(Feature) finalize immediately with the last vote #91

vbaranov opened this issue May 18, 2018 · 4 comments
Assignees
Milestone

Comments

@vbaranov
Copy link
Collaborator

Relates to poanetwork/RFC#8

@vbaranov vbaranov added this to the 2.0 milestone May 18, 2018
@vbaranov
Copy link
Collaborator Author

@varasev were you planning to include this feature request to refactored contracts?

@vbaranov vbaranov changed the title (Enhancement) finalize immediately with the last vote (Feature) finalize immediately with the last vote May 18, 2018
@varasev
Copy link
Contributor

varasev commented May 18, 2018

@vbaranov I wasn't, because this is a separate task, but if it's necessary, I'll give this task higher priority and include it in the current set of tasks that should be implemented before hard-fork.

@vbaranov
Copy link
Collaborator Author

@varasev no, this is a lower priority than block reward and additional emission

@varasev
Copy link
Contributor

varasev commented May 31, 2018

This was implemented and covered by tests in #113

I didn't include a calling of finalization function inside vote method because there can be a blocking (in case of any errors) if _finalizeBallot reverts, so the last validator won't be able to vote in this case and will be confused.

Therefore I suggest this implementation that assumes any validator should call finalize method separately by the same principle that works now.

These changes cover poanetwork/RFC#8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants