Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all tests to the new framework. #322

Open
7 of 8 tasks
afck opened this issue Nov 6, 2018 · 8 comments
Open
7 of 8 tasks

Port all tests to the new framework. #322

afck opened this issue Nov 6, 2018 · 8 comments

Comments

@afck
Copy link
Collaborator

afck commented Nov 6, 2018

We have two integration test frameworks at the moment, in tests/net and tests/network. We need to port all the tests to the former, and remove the latter:

  • binary_agreement_mitm.rs
  • binary_agreement.rs
  • broadcast.rs
  • honey_badger.rs
  • net_dynamic_hb.rs
  • queueing_honey_badger.rs
  • subset.rs
  • threshold_sign.rs
  • sync_key_gen.rs (if applicable?)
  • dynamic_honey_badger.rs
@afck afck assigned mbr Nov 6, 2018
@vkomenda
Copy link
Contributor

I'm not sure why there are two binary_agreement.rs tests in the list. I'll work on porting BA tests.

@afck
Copy link
Collaborator Author

afck commented Nov 12, 2018

Thanks, I removed the duplicate.

@vkomenda
Copy link
Contributor

I recorded in the checklist that the test of Binary Agreement has been updated in #336.

@vkomenda
Copy link
Contributor

test_threshold_sign_first_silent_50_samples fails sometimes which may indicate a bias but it's currently non-reproducible because it instantiates the RNG with thread_rng instead of using the proptest TestRng. This bug must be fixed as part of this bigger issue.

@dforsten
Copy link
Contributor

test_threshold_sign_first_silent_50_samples is now using TestRng, tolerance increased to 33% as suggested by @vkomenda in the discussions in PR #387.

@dforsten
Copy link
Contributor

sync_key_gen.rs does not use the old network simulator, should probably be taken off the list in this issue.

@dforsten
Copy link
Contributor

dynamic_honey_badger.rs is not present in the test folder any more, should probably be taken off the list in this issue as well.

@dforsten
Copy link
Contributor

PR #389, once merged, will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants