Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] Implement --no-ignore-vcs to disable automatic gitignore read #968

Open
ken-matsui opened this issue Aug 12, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ken-matsui
Copy link
Member

poac lint reads .gitignore by default if it exists, but we may sometimes want to avoid this behavior.

poac/src/Cmd/Lint.cc

Lines 37 to 49 in f32c760

// Read .gitignore if exists
if (fs::exists(".gitignore")) {
std::ifstream ifs(".gitignore");
std::string line;
while (std::getline(ifs, line)) {
if (line.empty() || line[0] == '#') {
continue;
}
cpplintCmd += " --exclude=";
cpplintCmd += line;
}
}

@ken-matsui ken-matsui added the good first issue Good for newcomers label Aug 12, 2024
@ken-matsui ken-matsui changed the title Implement --no-ignore for lint to disable automatic gitignore read Implement --no-ignore-vcs for lint to disable automatic gitignore read Aug 12, 2024
@ken-matsui ken-matsui changed the title Implement --no-ignore-vcs for lint to disable automatic gitignore read [lint] Implement --no-ignore-vcs to disable automatic gitignore read Aug 12, 2024
@ken-matsui ken-matsui added the enhancement New feature or request label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant