Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALC should isolate all relevant dependencies #4192

Closed
JustinGrote opened this issue Aug 27, 2024 · 1 comment
Closed

ALC should isolate all relevant dependencies #4192

JustinGrote opened this issue Aug 27, 2024 · 1 comment

Comments

@JustinGrote
Copy link

public class DependencyAssemblyLoadContext : AssemblyLoadContext

per PowerShell/vscode-powershell#3510 (comment), this does not appear to be isolating dependencies as expected, especially key ones that conflict with the Visual Studio Code PowerShell extension. As a result, several users are unable to run or debug PnP.PowerShell in Visual Studio Code but can get it to run otherwise.
PowerShell/vscode-powershell#5032

Please update the assembly load context and relevant references to properly isolate in PS7+. @jborean93 has an excellent loader example here: https://github.com/jborean93/PowerShell-ALC/blob/main/ALCLoader/README.md

@JustinGrote JustinGrote changed the title ALC should load all relevant dependencies ALC should isolate all relevant dependencies Aug 27, 2024
@jackpoz
Copy link
Contributor

jackpoz commented Aug 27, 2024

Note that I cannot confirm the issue reported at PowerShell/vscode-powershell#5032 , debugging works fine for me

image

Using [email protected] , PnP PowerShell 2.9.9, VS Code 1.92.2, PSVersion 7.4.5 .

The issue reported on VS Code shows HTTP error 404 which sounds unrelated to .NET isolation. The user most likely expects a list that doesn't exist.

@pnp pnp locked and limited conversation to collaborators Aug 27, 2024
@veronicageek veronicageek converted this issue into discussion #4194 Aug 27, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@jackpoz @JustinGrote and others