Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update options that have an aad prefix (like '--aadUserId') #5745

Closed
3 tasks
martinlingstuyl opened this issue Jan 3, 2024 · 2 comments
Closed
3 tasks

Update options that have an aad prefix (like '--aadUserId') #5745

martinlingstuyl opened this issue Jan 3, 2024 · 2 comments

Comments

@martinlingstuyl
Copy link
Contributor

martinlingstuyl commented Jan 3, 2024

There are some options that have an aad prefix. These need to be deprecated and given an new name:

  • Rename '--aadGroupIds' and '--aadGroupNames' option to '--entraGroupIds' and '--entraGroupNames' in 'spo group member add'. Deprecate the old options.
  • Rename '--aadGroupIds' and '--aadGroupNames' option to '--entraGroupIds' and '--entraGroupNames' in 'spo group member remove'. Deprecate the old options.
  • Rename '--aadId' option to '--entraId' in 'spo user ensure'. Deprecate the old option.
@SmitaNachan
Copy link
Contributor

Can I work on it?

@waldekmastykarz
Copy link
Member

Please do @SmitaNachan. Since this is a breaking change, we need to break it in the following steps:

  • introduce new options
  • mark old options as deprecated (incl. showing a warning when someone uses them)
  • create a new issue marked on hold that we'll take on when start working on v8 to remove the deprecated options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment