Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign layouts #584

Open
11 tasks
pngwn opened this issue Feb 23, 2024 · 2 comments
Open
11 tasks

Redesign layouts #584

pngwn opened this issue Feb 23, 2024 · 2 comments
Milestone

Comments

@pngwn
Copy link
Owner

pngwn commented Feb 23, 2024

The conversation around layouts has changed somewhat since the release of Sveltekit.

Questions:

  • Do we need layouts anymore? Can we achieve the same functionality with kit's layouts? What about other tools and integrations?
  • If we keep layouts can we somehow integrate directly with kit's layouts? Maybe we can use kits layouts for kit users but have builtin layouts as a fallback?
  • If we get rid of them what do we do about custom components

Related issues:

@pngwn pngwn added this to mdsvex Feb 23, 2024
@pngwn pngwn converted this from a draft issue Feb 23, 2024
@pngwn pngwn moved this from Triage + Refine to Todo in mdsvex Feb 23, 2024
@pngwn pngwn added this to the 1.0 milestone Feb 23, 2024
@pngwn pngwn mentioned this issue Feb 23, 2024
6 tasks
@zmre
Copy link

zmre commented May 24, 2024

There isn't an issue for it, but I don't think you can currently use data from, for example, a +layout.ts (so no server-side data available) and you also can't use stores like the page store, which tells you the current path of the current URL, for example, which makes it hard to put navigation elements into a "layout" for a mdsvex markdown file. I expect at least one if not both of these problems would be resolved if the kit layout system were being used and that would greatly simplify my code and keep me from having to do a bunch of data loading and displaying in the browser after first render to handle navigation stuff.

@pngwn
Copy link
Owner Author

pngwn commented May 25, 2024

Yes. I'm trying to figure how best to approach this issue both for kit and non-kit users.

I'm partly waiting to see what impact svelte 5 will have on kit before I make any concrete decisions.

@pngwn pngwn closed this as completed Aug 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in mdsvex Aug 17, 2024
@pngwn pngwn reopened this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants