Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpng18] spurious autoconf files #591

Closed
jbowler opened this issue Sep 15, 2024 · 4 comments
Closed

[libpng18] spurious autoconf files #591

jbowler opened this issue Sep 15, 2024 · 4 comments

Comments

@jbowler
Copy link
Contributor

jbowler commented Sep 15, 2024

scripts/autoconf remains even though the rest of the autoconf files have been deleted, this causes really weird behavior.

@jbowler jbowler mentioned this issue Sep 15, 2024
@ctruta
Copy link
Member

ctruta commented Sep 15, 2024

Ha! This:

# These are separate because 'maintainer-clean' does not remove them.

So I missed them.

@ctruta
Copy link
Member

ctruta commented Sep 15, 2024

Fixed.

@ctruta ctruta closed this as completed Sep 15, 2024
@ctruta
Copy link
Member

ctruta commented Sep 15, 2024

... and I missed your commit ff3f84f, which does this also.
In any case, I'll send an announcement to png-mng-implement, and I'll start picking up commits.

@jbowler
Copy link
Contributor Author

jbowler commented Sep 15, 2024

I'll start picking up commits.

Yeah; I layered the autoconf fix on all the other changes since I needed it to continue testing. I just revalidated the use-ISO-... fix so the now rebased #575, #589, #590 sequence are good to go. I've tested on Intel SSE and AArch64 (before the pngvalid/pngstest breaks).

I still don't know exactly how they got broken; I'm pretty sure I can find it but I don't want to do that if you are going to remove all the libpng 1.7 #ifs en masse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants