-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add python2.7 compatibility #255
Conversation
try python3 and fallback to python2
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 308 315 +7
=========================================
+ Hits 308 315 +7
Continue to review full report at Codecov.
|
Thanks for this @treymarc! Not everyone wants to touch 2.7 these days. One thing, do you mind adding See if that passes? |
update github action matrix
test are broken with python2.7 as they requires pytest>=6.1 :( ref : https://github.com/pndurette/gTTS/runs/1483489636 |
testing this code with python2.7 is working
|
pytest needs >= 6.1
Alright thanks @treymarc / @MarcTreySonos! We're already doing a big favour to the world by releasing an update for a 2.7 package. I did update Let me do something I haven't done in a while, build a 2.7 virtualenv to try that out. |
ensure python2.7 compatibility
revert to pytest 4.6.11
add python2.7 in the gh ci build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you forgot to change it here as well:
https://github.com/pndurette/gTTS/blob/master/setup.cfg#L44
Amazing, looks like Python 2.7 is back in business, against all odds. Thank you so much! |
Will release this shortly! |
thank you 👌 |
fix for #254
try python3 and fallback to python2
pytest should pass, lets see