Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(vanilla): do not handle promises #934

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Aug 18, 2024

a leftover in #810.

Copy link

vercel bot commented Aug 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 7:36am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Aug 18, 2024

commit: 68aa53a

pnpm add https://pkg.pr.new/valtio@934

Open in Stackblitz

Copy link

Size Change: -177 B (-1.45%)

Total Size: 12 kB

Filename Size Change
./dist/esm/vanilla.mjs 2.35 kB -88 B (-3.61%)
./dist/vanilla.js 2.38 kB -89 B (-3.61%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react.mjs 691 B
./dist/esm/react/utils.mjs 257 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla/utils.mjs 2.38 kB
./dist/index.js 243 B
./dist/react.js 681 B
./dist/react/utils.js 278 B
./dist/utils.js 248 B
./dist/vanilla/utils.js 2.41 kB

compressed-size-action

@dai-shi dai-shi merged commit 32cd09a into main Aug 18, 2024
29 checks passed
@dai-shi dai-shi deleted the breaking/drop-notify-promise branch August 18, 2024 13:21
Brooooooklyn referenced this pull request in toeverything/AFFiNE Aug 30, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [valtio](https://togithub.com/pmndrs/valtio) | [`^1.13.2` -> `^2.0.0`](https://renovatebot.com/diffs/npm/valtio/1.13.2/2.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/valtio/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/valtio/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/valtio/1.13.2/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/valtio/1.13.2/2.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>pmndrs/valtio (valtio)</summary>

### [`v2.0.0`](https://togithub.com/pmndrs/valtio/releases/tag/v2.0.0)

[Compare Source](https://togithub.com/pmndrs/valtio/compare/v1.13.2...v2.0.0)

### 🎉🎉🎉 Valtio v2 is Here! 🍾🍾🍾

#### Small Breaking Changes

Most users won't even notice the differences, but we recommend checking out the [migration guide](https://togithub.com/pmndrs/valtio/blob/main/docs/guides/migrating-to-v2.mdx) to ensure a smooth transition.

#### New Emoji

💊 -> 🧙

Say hello to our new emoji! This change symbolizes the magic of Valtio.

#### Let’s Grow the Ecosystem Together!

We are entering a new era of Valtio development, and we need your help to grow the ecosystem. Whether you are an experienced contributor or just getting started, now is the perfect time to join us!

#### What's Changed

-   v2 by [@&#8203;dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/valtio/pull/810](https://togithub.com/pmndrs/valtio/pull/810)
-   feat(core): expose internal states and functions by [@&#8203;dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/valtio/pull/931](https://togithub.com/pmndrs/valtio/pull/931)
-   breaking(vanilla): do not handle promises by [@&#8203;dai-shi](https://togithub.com/dai-shi) in [https://github.com/pmndrs/valtio/pull/934](https://togithub.com/pmndrs/valtio/pull/934)

#### New Contributors

-   [@&#8203;AmirSa12](https://togithub.com/AmirSa12) made their first contribution in [https://github.com/pmndrs/valtio/pull/898](https://togithub.com/pmndrs/valtio/pull/898)
-   [@&#8203;TotallyBiased](https://togithub.com/TotallyBiased) made their first contribution in [https://github.com/pmndrs/valtio/pull/901](https://togithub.com/pmndrs/valtio/pull/901)
-   [@&#8203;L-Qun](https://togithub.com/L-Qun) made their first contribution in [https://github.com/pmndrs/valtio/pull/908](https://togithub.com/pmndrs/valtio/pull/908)
-   [@&#8203;himself65](https://togithub.com/himself65) made their first contribution in [https://github.com/pmndrs/valtio/pull/920](https://togithub.com/pmndrs/valtio/pull/920)
-   [@&#8203;kciter](https://togithub.com/kciter) made their first contribution in [https://github.com/pmndrs/valtio/pull/922](https://togithub.com/pmndrs/valtio/pull/922)

**Full Changelog**: pmndrs/valtio@v1.13.2...v2.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/toeverything/AFFiNE).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6ImNhbmFyeSIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant