Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(support): incorrect type imports for rafz #1560

Merged
merged 1 commit into from
Jun 9, 2021
Merged

fix(support): incorrect type imports for rafz #1560

merged 1 commit into from
Jun 9, 2021

Conversation

sudkumar
Copy link
Contributor

@sudkumar sudkumar commented Jun 9, 2021

Why

Fixes #1559

What

Import type declarations from @react-spring/rafz instead of packages/rafz

Checklist

  • Documentation updates: Not required
  • Demo: Not needed
  • Ready to be merged: Yes

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c5120c:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit 6a08380 into pmndrs:master Jun 9, 2021
@sudkumar sudkumar deleted the patch-1 branch June 9, 2021 08:16
@0livare
Copy link

0livare commented Jun 9, 2021

Just encountered this and was going to make the same fix. Shoot, there goes my opportunity to contribute to react-spring haha

cameron-martin pushed a commit to cameron-martin/react-spring that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript issue in @react-spring/shared for Rafz
3 participants