-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/db v9 preconstruct #1379
Chore/db v9 preconstruct #1379
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit affbd47:
|
I'm sure you're still in the middle of things, but I've noticed you've accidentally committed the |
Ooops 😭 |
lets do it in another commit and use the same one in drei / r3f etc.
Okay so thats resolved yay However, one issue that concerns me is the use of Secondly, we need to add Thirdly, I've removed eslint for now – i'll add in a separate PR. Finally, i'm gonna merge this into a beta branch for us because I don't want it going master with such infrastructure changes. 💯 |
resolves #1459
Hey @dbismut, I'm going to merge this around midday tomorrow unless you have any additional thoughts? Luckily changesets can do the deps update that I was talking about that time keeping the package deps in sync with one another when we publish. Also i've managed to simplify the Great suggestion to do this, build and release is 10000000x faster 🚀 |
Wow awesome @joshuaellis! I have a lot going on at work atm so I'm not sure I'll be able to test this throughly but I'll definitely have a look when I can. Mid day as in Europe mid day? Anyway super happy this goes through! Looks like we're finally having a common ground for some repos in pmndrs! |
Yep European midday (somewhere around 1-3 CET) |
Move the build process to Preconstruct
This is a first attempt at simplifying the repo setup by using preconstruct. This might be going nowhere because of major no-gos that I'm not able to assess at this point!
What I've done
A lot of repeating tasks including:
tsconfig.json
filesrollup.config.js
filesmain
andmodule
entries inpackage.json
filesdemo
package as a yarn workspaceWhat seems to work
yarn demo:dev
launches the Vite js demo example and fetches the code directly from source without any aliasing. It works with preconstruct dev mode which is great.yarn build
does build, not sure if this meets the build requirements (upon rapid inspection, the build bundles seem to be slightly larger).What doesn't work yet
yarn test
fails because of typescript errorsyarn test:ts
also fails intargets/zdog
and__tests__/*
files. Note that it seems like I've enlarged the scope of the test files to all files included in the roottsconfig.json
, so maybe some of the throwing files were actually out of scope.Codesandbox fails to import@react-spring/types
New todos since the above is done