Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/db v9 preconstruct #1379

Merged
merged 35 commits into from
Apr 27, 2021
Merged

Chore/db v9 preconstruct #1379

merged 35 commits into from
Apr 27, 2021

Conversation

dbismut
Copy link
Contributor

@dbismut dbismut commented Mar 29, 2021

Move the build process to Preconstruct

This is a first attempt at simplifying the repo setup by using preconstruct. This might be going nowhere because of major no-gos that I'm not able to assess at this point!

What I've done

A lot of repeating tasks including:

  • remove tsconfig.json files
  • remove rollup.config.js files
  • properly configure main and module entries in package.json files
  • include the demo package as a yarn workspace

What seems to work

  • yarn demo:dev launches the Vite js demo example and fetches the code directly from source without any aliasing. It works with preconstruct dev mode which is great.
  • yarn build does build, not sure if this meets the build requirements (upon rapid inspection, the build bundles seem to be slightly larger).

What doesn't work yet

  • yarn test fails because of typescript errors
  • yarn test:ts also fails in targets/zdog and __tests__/* files. Note that it seems like I've enlarged the scope of the test files to all files included in the root tsconfig.json, so maybe some of the throwing files were actually out of scope.
  • Codesandbox fails to import @react-spring/types

New todos since the above is done

  • implement changeset
  • solve dependancy issue
  • aim to a beta branch

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit affbd47:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration

@joshuaellis
Copy link
Member

I'm sure you're still in the middle of things, but I've noticed you've accidentally committed the .bic-cache files.

@dbismut
Copy link
Contributor Author

dbismut commented Mar 29, 2021

Ooops 😭

@joshuaellis
Copy link
Member

Okay so thats resolved yay

However, one issue that concerns me is the use of * as the pkg dependancy, it causes a lot of agg if we release any Potentially breaking changes see #1414. So ideally we need some sort of script(?) to keep them all in check? 🤔

Secondly, we need to add changesets to this PR.

Thirdly, I've removed eslint for now – i'll add in a separate PR.

Finally, i'm gonna merge this into a beta branch for us because I don't want it going master with such infrastructure changes.

💯

@joshuaellis joshuaellis changed the base branch from master to beta April 26, 2021 21:09
@joshuaellis joshuaellis marked this pull request as ready for review April 26, 2021 21:59
@joshuaellis joshuaellis linked an issue Apr 26, 2021 that may be closed by this pull request
@joshuaellis
Copy link
Member

Hey @dbismut,

I'm going to merge this around midday tomorrow unless you have any additional thoughts? Luckily changesets can do the deps update that I was talking about that time keeping the package deps in sync with one another when we publish.

Also i've managed to simplify the jest.config.js no idea why that was over engineered.... What we can do is release 9.2.0 as a beta, check out our demos and make sure they're still fine and then merge to master to finish the change.

Great suggestion to do this, build and release is 10000000x faster 🚀

@dbismut
Copy link
Contributor Author

dbismut commented Apr 26, 2021

Wow awesome @joshuaellis! I have a lot going on at work atm so I'm not sure I'll be able to test this throughly but I'll definitely have a look when I can. Mid day as in Europe mid day?

Anyway super happy this goes through! Looks like we're finally having a common ground for some repos in pmndrs!

@joshuaellis
Copy link
Member

Yep European midday (somewhere around 1-3 CET)

@joshuaellis joshuaellis merged commit c1b9e80 into beta Apr 27, 2021
@joshuaellis joshuaellis deleted the chore/db-v9-preconstruct branch April 27, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] Recrawl doesn't run on Windows
2 participants