Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0191_1.20.80.24_beta_to_1.21.0.25_beta.json #1

Closed
wants to merge 1 commit into from

Conversation

RaphiMC
Copy link

@RaphiMC RaphiMC commented Jun 14, 2024

Adds 3 missing upgrade rules for coral_block. Tested by sending the items to the bedrock client and observing the outcome (Meta values is item count - 1).
image

The mapping for tallgrass seems to be complete according to the results you get when giving the item with different meta values:
image

@dktapps
Copy link
Member

dktapps commented Jun 15, 2024

These were intentionally not included as the missing ones get folded to 0 anyway

@dktapps dktapps closed this Jun 15, 2024
@RaphiMC
Copy link
Author

RaphiMC commented Jun 15, 2024

These were intentionally not included as the missing ones get folded to 0 anyway

This is wrong tho, as the mapping for 0 is minecraft:tube_coral_block while the mapping for 13, 14, 15 should be minecraft:dead_tube_coral_block

@dktapps
Copy link
Member

dktapps commented Jun 16, 2024

They are invalid states, so it doesn't really make any difference. It only works that way in the main game because of a default case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants