const injected in runtime code

[Donov4n]

Thanks for this super cool project!

In RefreshModule.runtime.js, const are injected in runtime code and will not be transpiled (since it's a loader injected code).

This is critical in old browser that do not support const in strict mode for example.

Elsewhere in the codebase i've seen a supportsConst method that seems to handle this specific case, maybe the code injected by RefreshModule.runtime.jsshould do the same.

[pmmmwh]

Hi, that is actually done deliberately on purpose. All modern browser since 2016 have working implementations of const and let (and also IE11 supports it). Are you facing specific issues where that would break your code?

[Donov4n]

We are trying to replace RHL with react-refresh but we need to support old browsers (like Chrome 30-40 f.e) but these const are breaking our code with errors like "SyntaxError: Use of const in strict mode".

It seems sad to me to not support all the projects that need to take into account old browsers (not only IE) just because of these few line 😞 but if it's done deliberately, maybe this should be explicitly said in the README / FAQ (?).

[pmmmwh]

We are trying to replace RHL with react-refresh but we need to support old browsers (like Chrome 30-40 f.e) but these const are breaking our code with errors like "SyntaxError: Use of const in strict mode".

It seems sad to me to not support all the projects that need to take into account old browsers (not only IE) just because of these few line 😞 but if it's done deliberately, maybe this should be explicitly said in the README / FAQ (?).

I understand the frustration - I'll look into it, in particular I don't think we rely on any scoping behaviours from const and let.

[TrySound]

Just wondering why do you support chrome 30-40? They did not get security updates for 5 or more years already.
Is it even possible to test them?

[Donov4n]

Just wondering why do you support chrome 30-40? They did not get security updates for 5 or more years already.
Is it even possible to test them?

This bug can be seen in all browsers versions that don’t support const / let in strict mode, not only Chrome 30-40.
(f.e. If you want to support iPhone 4S, iPad 2 ...)

For our case, we support Chrome since v30 because the platforms (old tv) where our project is run can’t update to newer version of chrome.

[pmmmwh]

To be honest, the pragmatist in me definitely does not want to support these browsers, but given React supports browsers down to IE9 I'm not sure about how compelling our argument on this case would be.

However, given that Webpack 5 now does have APIs to selectively target specific environments and we already lean on it with the crucial runtime init code, maybe it makes sense to actually use that more to ensure not only compat with older browsers but also pure ESM environments (#294).

It does make the template code more difficult to maintain and lint because now it is not really pure JavaScript.

[Donov4n]

Like said, it’s not only for Chrome 30-40, this bug is viewable on iOS 9, which imply supporting (or not) iPad 2, iPhone 4S ...

+1 for the fact that React itself supports IE >= 9.