-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some rounding and error messaging for subplots #4153
Adding some rounding and error messaging for subplots #4153
Conversation
@AaronStiff - this is the PR to close #4124 - I mostly moved over your code here. I am seeing an NPM error in the CI/CD process though. Would you be available to review? |
@stephenpardy Great! I'm not really familiar with/involved in the build process though, but maybe @nicolaskruchten you could take a look? It would appear several other PRs are failing with the same issue. |
@alexcjohnson can you review this one plz? I'm not really available for the next few days |
@AaronStiff, @nicolaskruchten, or @alexcjohnson - just want to give this a gentle nudge to see if anyone is able to review and/or discuss the NPM build failure - I see that it is still around in some other PRs as well. Thank you. |
Thanks @stephenpardy - we did some other work in the last few days to fix build/CI issues so with any luck the tests will pass now that I updated the branch. Would you be able to add a test of the problem you're fixing, as well as an entry in the changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Beautiful, thank you!
Code PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
-->