Use npm v7 and node.js 16 in development and testing #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Sep 3, 2021
| @@ -972,7 +972,7 @@ describe('Pie traces', function() { | |||
| textposition: [['outside', 'outside', 'inside', 'inside', 'outside']], | |||
| 'outsidetextfont.size': 12 | |||
| }, { | |||
| t: '~=', l: '~=', | |||
| t: '~=', l: 'shrunk', | |||
There was a problem hiding this comment.
Bring back the original test which was tweaked in e01d09a.
alexcjohnson
reviewed
Sep 3, 2021
| @@ -1449,7 +1449,7 @@ describe('axis zoom/pan and main plot zoom', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('panning a matching overlaying axis', function(done) { | |||
| it('@noCI panning a matching overlaying axis', function(done) { | |||
There was a problem hiding this comment.
Instead of @noCI can we just increase the tolerance a bit?
There was a problem hiding this comment.
This test passes locally. We did reduce the number of noCI test when compared to pre-v2 era.
I hope in near future we could spend some time to bring that down to zero.
This is I think possible by ensuring the needed fonts installed in the jasmine containers.
So if you don't mind I keep this flag and instead open an issue to track it?
There was a problem hiding this comment.
Sure, that's fine. Thanks for the tracking issue.
alexcjohnson
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5921 and fixes the issue with listing forked modules required to address #897.
@plotly/plotly_js