Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download plot as a png not working in IE from 1.13.0 #699

Closed
fixxxr opened this issue Jun 28, 2016 · 10 comments
Closed

Download plot as a png not working in IE from 1.13.0 #699

fixxxr opened this issue Jun 28, 2016 · 10 comments
Labels
bug something broken

Comments

@fixxxr
Copy link

fixxxr commented Jun 28, 2016

From release 1.13.0 the snapshot in IE (svg) seems broken.
tested with type: 'surface' and type: 'contour' and for the first it produces a blank svg while for the second, the snapshot seems to stop before the saving of the svg file.

From 1.12.0 and below the snapshot for type: 'contour' has the same behavior as described above.

@etpinard
Copy link
Contributor

Thanks for the report.

We did make some changes to our to-image code in 1.13.0 (See PR #604).

Can you confirm or infirm the following:

Donwload plot with

  • type: 'surface' does not work in IE11 with plotly.js 1.13.0 ?
  • type: 'surface' works in IE11 with plotly.js 1.12.0 ?
  • type: 'surface' works in IE11 with plotly.js 1.11.0 ?
  • type: 'contour' does not work in IE11 with plotly.js 1.13.0 ?
  • type: 'contour' does not work in IE11 with plotly.js 1.12.0 ?
  • type: 'contour' does not work in IE11 with plotly.js 1.11.0 ?

To-image support for IE11 was introduced in 1.11.0 (see PR #446), so there no chance of it working in versions < 1.11.0.

cc @timelyportfolio

@etpinard etpinard added the bug something broken label Jun 28, 2016
@fixxxr
Copy link
Author

fixxxr commented Jun 28, 2016

in order:

  1. Yes
  2. Yes
  3. Yes
  4. Yes
  5. Yes
  6. Yes

Below 1.12.0 is for down to 1.11.0

Thanks

@timelyportfolio
Copy link
Contributor

timelyportfolio commented Jun 28, 2016

@fixxxr, I'll check. Could you provide the code you are using to make your png, or are you using the snapshot button? Sorry for the troubles.

@fixxxr
Copy link
Author

fixxxr commented Jun 29, 2016

I am using the snapshot button.
Also I tested the aforementioned releases with the example posted here: plotly.surface, just to be sure that it wasn't related only to my case. I confirm that the issue is reproducible with the code posted on Plotly's page.

@timelyportfolio
Copy link
Contributor

Looking into this, and I think I see the issue. I'll keep working on it and hopefully by tomorrow I will have it fixed.

@fixxxr
Copy link
Author

fixxxr commented Jun 30, 2016

@timelyportfolio, thank you very much

@fixxxr
Copy link
Author

fixxxr commented Oct 12, 2016

hi there,
any news on this issue?

@etpinard
Copy link
Contributor

From @vsabeti :

PNG toImage for IE Edge works if img.crossOrigin is set to 'Anonymous'. The tainted canvas is fixed for the Edge browser (and works with this one change), but apparently will not be fixed for IE11. https://connect.microsoft.com/IE/feedback/details/828416/cavas-todataurl-method-doesnt-work-after-draw-svg-file-to-canvas
It would be great if in a future plotlyjs release, toImage png format is allowed for Edge while still restricting IE11 and below to be svg format only.

@ravidixit
Copy link

@etpinard so does this mean that we cannot use the toImage method in IE 11, but will work in IE Edge for windows 10 with crossOrigin, please let me know if I have understood it correct.
Also if toImagemethod is not supported for IE11 then what are the alternatives for the same.
As suggested I have tried the toImagemethod with svgformat and it fails to render in IE 11
In my above query #1103 I have added a JSfiddle which makes use of canvas but its working in chrome and Firefox but fails in IE 11.

@cldougl cldougl changed the title Donwload plot as a png not working in IE from 1.13.0 Download plot as a png not working in IE from 1.13.0 Nov 29, 2016
@alexcjohnson
Copy link
Collaborator

superseded by #2077 for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

5 participants