Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render newshape text and texttemplate during initial shape draw #6540

Closed
emilykl opened this issue Mar 29, 2023 · 0 comments · Fixed by #6608
Closed

Render newshape text and texttemplate during initial shape draw #6540

emilykl opened this issue Mar 29, 2023 · 0 comments · Fixed by #6608

Comments

@emilykl
Copy link
Contributor

emilykl commented Mar 29, 2023

Currently, if a shape label is defined in newshape using text or texttemplate, the text is not rendered until mouseup following the initial draw.

Modify shape drawing code such that the text is rendered during mousedown.

This is doable, but involves some additional complexity since the initial shape drawing code (during mousedown) is completely separate from the normal shape drawing code, and we don't have access to the same set of variables.

Implementation will involve modifying key lines in src/components/selections/select.js and possibly src/components/shapes/display_outlines.js due to the overlap between selection and shape code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant