Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scattergl in strict-bundle still requires unsafe-eval #6140

Closed
CallumNZ opened this issue Mar 14, 2022 · 3 comments
Closed

Scattergl in strict-bundle still requires unsafe-eval #6140

CallumNZ opened this issue Mar 14, 2022 · 3 comments
Labels
bug something broken

Comments

@CallumNZ
Copy link
Contributor

scattergl was added to the strict bundle in the most recent release: https://github.com/plotly/plotly.js/releases/tag/v2.11.0

I tried it out but it seems to still need unsafe-eval in the script-src directive of the CSP to work.

Bug replication Codepen:

https://codepen.io/CallumNZ/pen/ExoarRE?editors=1111

@archmoj archmoj added the bug something broken label Mar 15, 2022
@archmoj
Copy link
Contributor

archmoj commented Mar 15, 2022

Thanks for the report @CallumNZ.
cc: @yujin-wu, it appears while generating the functions using "unchecked" regl similar to this initial commit was needed.

@archmoj
Copy link
Contributor

archmoj commented Mar 15, 2022

Fixed by #6141 in v2.11.1 | Codepen

@archmoj archmoj closed this as completed Mar 15, 2022
@alexcjohnson
Copy link
Collaborator

@archmoj Your fix works, but your codepen still fails for me. I haven't looked at why, but here's one minimally tweaked from @CallumNZ 's codepen, that does work for me: https://codepen.io/alexcjohnson/pen/GRyJBbr?editors=1111

@CallumNZ thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants